| From: | Zhang Mingli <zmlpostgres(at)gmail(dot)com> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix outdated code comments in nodeAgg.c |
| Date: | 2025-02-18 12:11:22 |
| Message-ID: | 9b43912c-fbcd-430b-b4ea-b15df3401270@Spark |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Feb 10, 2025 at 16:45 +0800, Richard Guo <guofenglinux(at)gmail(dot)com>, wrote:
> On Sun, Feb 9, 2025 at 11:15 PM Zhang Mingli <zmlpostgres(at)gmail(dot)com> wrote:
> > By reading the codes in nodeAgg.c, I found that some comments are outdated.
> > The comments referred to the function lookup_hash_entry(), which has been removed in commit b563594.
> > I've adjusted the comments to refer to the correct function to make it clear.
>
> LGTM. This seems to be an oversight from 200f6100a, in which the
> function lookup_hash_entry() was removed.
>
> Thanks
> Richard
Hi,
Thanks for review, added it to commitfest https://commitfest.postgresql.org/patch/5580/
--
Zhang Mingli
HashData
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2025-02-18 12:29:27 | Re: Support a wildcard in backtrace_functions |
| Previous Message | Zhang Mingli | 2025-02-18 12:07:18 | Re: Proposal to CREATE FOREIGN TABLE LIKE |