From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Japin Li <japinli(at)hotmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Another incorrect comment for pg_stat_statements |
Date: | 2023-06-28 08:27:00 |
Message-ID: | CAMbWs4-PkT_gdpzLoD_6aW2XaQCwzMN3JujXA6q4JXik=_dQzQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jun 28, 2023 at 3:36 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Wed, Jun 28, 2023 at 03:09:55PM +0800, Richard Guo wrote:
> > +1. To nitpick, how about we remove the blank line just before removing
> > the key for top level entry?
> >
> > - /* Also remove entries for top level statements */
> > + /* Also remove entries if exist for top level statements */
> > key.toplevel = true;
> > -
> > - /* Remove the key if exists */
> > entry = (pgssEntry *) hash_search(pgss_hash, &key, HASH_REMOVE, NULL);
>
> Why not if it improves the overall situation. Could you send a patch
> with everything you have in mind?
Here is the patch. I don't have too much in mind, so the patch just
removes the blank line and revises the comment a bit.
Thanks
Richard
Attachment | Content-Type | Size |
---|---|---|
v1-0001-trivial-revise-for-entry_reset.patch | application/octet-stream | 994 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2023-06-28 08:29:14 | Re: [PATCH] Support % wildcard in extension upgrade filenames |
Previous Message | Peter Eisentraut | 2023-06-28 08:13:38 | Re: Changing types of block and chunk sizes in memory contexts |