Re: Require suggestions for Issue #2874

On Thu, Sep 5, 2024 at 7:11 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
Hi,

Hi
>
> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <rohit(dot)bhati(at)enterprisedb(dot)com>
> wrote:
>
>> Hi,
>>
>> I have made changes for issue #7863
>> <https://github.com/pgadmin-org/pgadmin4/issues/7863> based on theme
>> requirements.
>>
>> I have attached screenshots showing how the updates look across all
>> themes for your reference.
>>
>> If the current color does not fit well with the theme or if you have any
>> suggestions for improvements, please let me know.
>>
>
> Is the colour contrast high enough on the row numbers for selected rows in
> the high contrast theme? The black on grey seems like it might not be to
> me, but I haven't tested.
>
> I wonder also if we should make the row numbers bold all the time.
> Thoughts?
>

Yes. We should.

> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> EDB: https://www.enterprisedb.com
>
> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>
>