Re: Require suggestions for Issue #2874

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Rohit Bhati <rohit(dot)bhati(at)enterprisedb(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Require suggestions for Issue #2874
Date: 2024-09-05 13:41:31
Message-ID: CA+OCxoy5Mz53vyebx+2V0U3KH9f+Pd-p-HWoM7dMnUYNrjP-nw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <rohit(dot)bhati(at)enterprisedb(dot)com>
wrote:

> Hi,
>
> I have made changes for issue #7863
> <https://github.com/pgadmin-org/pgadmin4/issues/7863> based on theme
> requirements.
>
> I have attached screenshots showing how the updates look across all themes
> for your reference.
>
> If the current color does not fit well with the theme or if you have any
> suggestions for improvements, please let me know.
>

Is the colour contrast high enough on the row numbers for selected rows in
the high contrast theme? The black on grey seems like it might not be to
me, but I haven't tested.

I wonder also if we should make the row numbers bold all the time. Thoughts?

--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
EDB: https://www.enterprisedb.com

PGDay UK 2024, 11th September, London: https://2024.pgday.uk/

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Yogesh Mahajan 2024-09-06 04:39:13 Re: Require suggestions for Issue #2874
Previous Message Rohit Bhati 2024-09-05 13:38:20 Re: Require suggestions for Issue #2874