Re: [pgAdmin][RM5017] Use cheroot as default production server

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM5017] Use cheroot as default production server
Date: 2019-12-20 12:51:39
Message-ID: CAM9w-_ny_icvP7SCqAQ9CdeOnRWaAeeX4esSYkP2dHCQcjtXNA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Ashesh,

I had tried with - https://newrelic.com/ API to check Flask app
performance. To be honest, there was not a great difference in the
performance.
Per new relic, cheroot used slightly less CPU, with more RPM and, with less
response time.
Anyway, flask is still not recommended and cheroot looks a good option as
it is pure python and supports almost all OS.

On Fri, Dec 20, 2019 at 1:34 PM Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
wrote:

> Have you seen any improvements in performance?
>
> On Tue, 17 Dec 2019, 15:16 Aditya Toshniwal, <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to use https://pypi.org/project/cheroot/ instead
>> of current flask dev server. cheroot is a stable production ready server.
>> Plus, flask dev server is not recommended for production.
>> Code is changed to use cheroot only when DEBUG is False, otherwise you
>> the default flask server.
>>
>> Kindly review.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2019-12-20 13:13:58 pgAdmin 4 commit: 1) Refactored SQL of Table's and it's child nodes. Fi
Previous Message Murtuza Zabuawala 2019-12-20 12:16:58 [pgAdmin4][RM#4772] Add aria-label attribute to buttons used in graphical explain plan