Re: [pgAdmin][RM5017] Use cheroot as default production server

Hi Hackers,

One of the dependencies of cheroot - jaraco.functools was released on 20th
Dec (v 3.0.0) which removed the support below Python 3.6. So while
installing cheroot (using pgAdmin wheel) on Python 3.5, it is failing.
cheroot works fine with its previous version of jaraco.functools==2.0.0.
I've raised the issue to cheroot -
https://github.com/cherrypy/cheroot/issues/258.
Please note, installers work fine as they are shipped with Python 3.7 venv.
Ref - https://www.postgresql.org/ftp/pgadmin/pgadmin4/snapshots/2019-12-24/
Attached is the patch to pin jaraco.functools to 2.0.0 in requirements so
that it does not fail below Python 3.6.

On Fri, Dec 20, 2019 at 6:21 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Ashesh,
>
> I had tried with - https://newrelic.com/ API to check Flask app
> performance. To be honest, there was not a great difference in the
> performance.
> Per new relic, cheroot used slightly less CPU, with more RPM and, with
> less response time.
> Anyway, flask is still not recommended and cheroot looks a good option as
> it is pure python and supports almost all OS.
>
> On Fri, Dec 20, 2019 at 1:34 PM Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Have you seen any improvements in performance?
>>
>> On Tue, 17 Dec 2019, 15:16 Aditya Toshniwal, <
>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to use https://pypi.org/project/cheroot/ instead
>>> of current flask dev server. cheroot is a stable production ready server.
>>> Plus, flask dev server is not recommended for production.
>>> Code is changed to use cheroot only when DEBUG is False, otherwise you
>>> the default flask server.
>>>
>>> Kindly review.
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"