| From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | [pgAdmin4][RM#3238] Proper error handling when connection will be lost to server. |
| Date: | 2018-05-03 10:23:23 |
| Message-ID: | CAM9w-_nmzThAbpFUaZmVB3sJJGVeLRSqgUtsB8SAgfb1ok50zQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Hackers,
PFA patch for proper error handling when connection will be lost to server.
I have created a common function alertify.pgRespErrorNotify in
web/pgadmin/static/js/alertify.pgadmin.defaults.js on the lines of existing
function alertify.pgNotifier. The function is called in error callback of
$.ajax call. The XHR is passed and handled in the function itself. Please
note that I have used JSON.parse and not $.parseJSON as it will be
deprecated in jQuery 3.x and thus removing many $.parseJSON calls.
Request you to kindly review.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
| Attachment | Content-Type | Size |
|---|---|---|
| RM3238.patch | text/x-patch | 26.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2018-05-03 10:38:05 | Re: [pgAdmin4][RM#3238] Proper error handling when connection will be lost to server. |
| Previous Message | Khushboo Vashi | 2018-05-03 09:25:48 | Re: [pgAdmin4][Patch]: Fixed RMs #1220 & #1221 |