Re: [pgAdmin4][RM#3238] Proper error handling when connection will be lost to server.

Hi

On Thu, May 3, 2018 at 11:23 AM, Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> PFA patch for proper error handling when connection will be lost to
> server. I have created a common function alertify.pgRespErrorNotify in
> web/pgadmin/static/js/alertify.pgadmin.defaults.js on the lines of
> existing function alertify.pgNotifier. The function is called in error
> callback of $.ajax call. The XHR is passed and handled in the function
> itself. Please note that I have used JSON.parse and not $.parseJSON as it
> will be deprecated in jQuery 3.x and thus removing many $.parseJSON calls.
>
> Request you to kindly review.
>

Can you add some appropriate tests for the new function please?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company