From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
---|---|
To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | [pgAdmin4][RM3294] User need to reset the layout to see the changed preferences parameters |
Date: | 2018-06-28 14:34:33 |
Message-ID: | CAM9w-_nZikTmx0JkrDyev3Z8qk26MskoEF2=N1T2-Ji-mK8Q-Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Hackers,
Attached is the patch for making preferences realtime and applying without
reseting the layout. Please note, the patch is only for one module - SQL
Editor and is the first part for the RM. There are lot of changes to be
done to cover all and hence sending in parts. This will not affect/break
existing code. Further patches will cover other modules.
Highlights of this patch include:
- Changes will affect SQL Editors in Create dialog boxes, SQL tab of the
main screen, Query tool, History entries in the query tool, Query tool
opened in New Tab/Window
- All the components of SQL editor will refer to single source of
preferences which is cached in the Browser object. All other redundant ajax
get preference calls are removed.
- SQL editor will not refer template JS variables anymore, once all the
references are removed the template variables will also be removed.
- Code refactoring wherever possible.
- Covered JS test cases wherever possible.
Request you to kindly review.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
Attachment | Content-Type | Size |
---|---|---|
0001-RM3294.patch | application/octet-stream | 106.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2018-06-28 14:39:50 | pgAdmin 4 commit: Minor tweaks to the Debian build. |
Previous Message | Dave Page | 2018-06-28 13:57:57 | Re: pgAdmin 4 v3.1 Released |