[pgAdmin][RM4590] Schema Backup fails with names that requires quoting

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin][RM4590] Schema Backup fails with names that requires quoting
Date: 2019-10-03 10:23:23
Message-ID: CAM9w-_nYdZC73Tynv+QAzGtYeStsn2hEKa02B-fSxK3_EVCmCw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Attached is the patch to fix the schema backup with names that requires
double quotes.
Command line has special meaning for double quotes and so the command is
run without the double quotes if applied on objects. Code is changed to add
extra pairs of quotes to save our object quotes.

Also fixed a test case which was failing if certain paths had spaces in
between.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

Attachment Content-Type Size
RM4590.patch application/octet-stream 3.1 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2019-10-03 11:16:11 [pgAdmin][RM4728] more strongly highlight the closing or opening parenthesis when the cursor is over one
Previous Message Aditya Toshniwal 2019-10-03 07:10:07 Re: [pgAdmin][RM4701] Webpack optimization