From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
---|---|
To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM4590] Schema Backup fails with names that requires quoting |
Date: | 2019-10-08 12:16:03 |
Message-ID: | CAM9w-_=NNvVYKu4U1C1vALQ6dJjjkWy9NztcURvoy7yb9SWobA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Hackers,
Turned out to be an issue only on Mac. Backup works fine for other OS.
Attached is the patch to fix the issue on Mac. Code is changed to add extra
pairs of quotes wherever required on MacOS.
Kindly review.
On Thu, Oct 3, 2019 at 3:53 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Attached is the patch to fix the schema backup with names that requires
> double quotes.
> Command line has special meaning for double quotes and so the command is
> run without the double quotes if applied on objects. Code is changed to add
> extra pairs of quotes to save our object quotes.
>
> Also fixed a test case which was failing if certain paths had spaces in
> between.
>
> Kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachment | Content-Type | Size |
---|---|---|
RM4590_V2.patch | application/octet-stream | 6.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2019-10-09 06:31:57 | pgAdmin 4 commit: Feature test should work with Python 2.7. |
Previous Message | Dave Page | 2019-10-08 11:43:46 | Re: pgAdmin 4 commit: Fixes # 4778 - Implement the query plan analyzer |