Re: Remove hacky way to open/close the dropdown-submenu

Hi Ashesh,

All works good, except one small change. Submenus should be closed if I
press Esc and then reopen the menu.

On Thu, Jan 31, 2019 at 11:32 AM Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
wrote:

> Hi Aditya,
>
> On Tue, Jan 22, 2019 at 10:25 AM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Ashesh,
>>
>> I am getting a syntax error on bundle.
>> After fixing that, please look into this scenario:
>> Using keyboard shortcuts open object menu, for eg on table node. Go to
>> any submenu using keyboard and go to any submenu and press enter.
>> Now open object menu again using keyboard shortcut, the submenu remains
>> open. It should be closed.
>>
> Please find the updated patch with all comments fixed.
> Now - whenever the callback for the menu is called (menu toggling), it
> will close the existing submenu(s) too.
>
> Please review it, and let me know.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com/>
>
>
> *http://www.linkedin.com/in/asheshvashi
> <http://www.linkedin.com/in/asheshvashi>*
>
>
>>
>> Everything looks fine to me except the above.
>>
>>
>> On Tue, Jan 22, 2019 at 10:07 AM Ashesh Vashi <
>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Any update?
>>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>> <http://www.enterprisedb.com>
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>> <http://www.linkedin.com/in/asheshvashi>
>>>
>>>
>>> On Thu, Jan 17, 2019 at 7:39 PM Ashesh Vashi <
>>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Aditya/Khushboo,
>>>>
>>>> I can see a hacky way to open/close the dropdown-submenu in the menu.js
>>>> file.
>>>> I've followed a more general way to open/close any submenu in the
>>>> dropdown list, instead of just 'Objects' menu.
>>>>
>>>> Can you please review it, and let me know your thoughts?
>>>> Let me know if you have any other better approach.
>>>>
>>>>
>>>> --
>>>>
>>>> Thanks & Regards,
>>>>
>>>> Ashesh Vashi
>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>> <http://www.enterprisedb.com>
>>>>
>>>>
>>>> *http://www.linkedin.com/in/asheshvashi*
>>>> <http://www.linkedin.com/in/asheshvashi>
>>>>
>>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"