Re: [pgAdmin][SonarQube] Shadowing variables

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Cc: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Subject: Re: [pgAdmin][SonarQube] Shadowing variables
Date: 2020-07-16 09:40:38
Message-ID: CAM9w-_my=+QBRPTY2fQ58_9CP4NmN6r931hBTjVNAPNbKeGaaA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Attached is the patch to fix a few more SonarQube reported issues(around
28) related to "potential hiding of variables declared in an outer scope".
Please review.

On Tue, Jul 14, 2020 at 4:06 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Thanks, patch applied.
>
> On Mon, Jul 13, 2020 at 10:15 AM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to fix the SonarQube reported issues (40+)
>> which potentially hides a variable declared in an outer scope.
>>
>> Please review.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--
Regards,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
<http://edbpostgres.com>
"Don't Complain about Heat, Plant a TREE"

Attachment Content-Type Size
sonarqube.shadowing.part2.patch application/octet-stream 17.0 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2020-07-16 09:41:03 Runtime refactoring
Previous Message Akshay Joshi 2020-07-15 12:38:03 pgAdmin 4 commit: Added docstrings for some newly created functions.