| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Runtime refactoring |
| Date: | 2020-07-16 09:41:03 |
| Message-ID: | CA+OCxoy1C83iDuSEnhMk1z3K+y=1-7BL8xd81++iueo2fd+iiQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Here's a pretty large patch that implements a major refactoring of the
runtime code. Specifically:
- Move the bulk of the core code from main() into a new Runtime class.
- Break up the mass of code that was main() into a number of relatively
simple functions.
- Make the Configuration dialog synchronous so the Log dialog can be
properly viewed.
- Enable/disable menu options at the right time.
- Remove support for Qt < 5.0.
- Remove the application name constant and hardcode the name to simplify
the code.
- Improve log messages.
- Replace the sdbm hashing with Qt's MD5 hashing.
Please review & test, but do not commit before next week's release.
Thanks!
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
| Attachment | Content-Type | Size |
|---|---|---|
| Major_runtime_refactor.patch | application/octet-stream | 66.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Satish V | 2020-07-16 11:38:07 | [pgAdmin 4 - Bug #5137] Focussing in and then out of numeric input enables the save button in dialog |
| Previous Message | Aditya Toshniwal | 2020-07-16 09:40:38 | Re: [pgAdmin][SonarQube] Shadowing variables |