Re: JS Test error on Windows

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Subject: Re: JS Test error on Windows
Date: 2018-05-11 06:28:50
Message-ID: CAM9w-_mdZpufmv2mmKPiyciWUynPfGVQCOiWijPGHdbPba2_eg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave/Hackers,

PFA fix for the problem. The RegEx for webpack test is not working on
windows because the path separator is different for Windows( \ ) and Unix(
/ ). And so, the imports loader is not executing for slickgrid.
Patch tested on Win 10, Win 7, Ubuntu, Cent OS and works fine.

Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

On Fri, Apr 27, 2018 at 5:34 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

>
>
> On Fri, Apr 27, 2018 at 10:49 AM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Not sure if that's the case but possibly security mechanism on Win2016
>> somehow interfering with Headless chrome execution.
>>
>
> Maybe - I cannot find anything obvious through Google though. I have
> already disabled the firewall entirely.
>
>
>>
>>
>> On Fri, Apr 27, 2018 at 2:44 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Anyone? Khushboo, Murtuza; any ideas?
>>>
>>> On Wed, Apr 25, 2018 at 4:45 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> Hi
>>>>
>>>> Setting up an new build system running Windows 2016 and I'm hitting an
>>>> error with the JS tests as below. I have Yarn 1.6.0, Node 8.11.1 and get
>>>> the following error running yarn run test:karma-once. The linter and
>>>> bundler work fine, FWIW, and I see the same error running either manually
>>>> or through Jenkins. jquery.event.drag 2.2 and 2.3.0 are in the slickgrid
>>>> lib directory. Chrome is 66.0.3359.117.
>>>>
>>>> Does anyone have any idea what's going on?
>>>>
>>>> webpack: Compiled successfully.
>>>> HeadlessChrome 0.0.0 (Windows 10 0.0.0) ERROR
>>>> {
>>>> "message": "Uncaught Error: SlickGrid requires jquery.event.drag
>>>> module to be loaded\nat regression/javascript/selectio
>>>> n/column_selector_spec.js:13842:3\n\nError: SlickGrid requires
>>>> jquery.event.drag module to be loaded\n at Object.<anonymous>
>>>> (regression/javascript/selection/column_selector_spec.js:13842:9)\n
>>>> at Object.5 (regression/javascript/selecti
>>>> on/column_selector_spec.js:17810:30)\n at __webpack_require__
>>>> (regression/javascript/selection/column_selector_spec.js:20:30)\n
>>>> at Object.904 (regression/javascript/selecti
>>>> on/column_selector_spec.js:18335:1)\n at __webpack_require__
>>>> (regression/javascript/selection/column_selector_spec.js:20:30)\n
>>>> at regression/javascript/selection/column_selector_spec.js:63:18\n
>>>> at regression/javascript/selection/column_selector_spec.js:66:10",
>>>> "str": "Uncaught Error: SlickGrid requires jquery.event.drag module
>>>> to be loaded\nat regression/javascript/selectio
>>>> n/column_selector_spec.js:13842:3\n\nError: SlickGrid requires
>>>> jquery.event.drag module to be loaded\n at Object.<anonymous>
>>>> (regression/javascript/selection/column_selector_spec.js:13842:9)\n
>>>> at Object.5 (regression/javascript/selecti
>>>> on/column_selector_spec.js:17810:30)\n at __webpack_require__
>>>> (regression/javascript/selection/column_selector_spec.js:20:30)\n
>>>> at Object.904 (regression/javascript/selecti
>>>> on/column_selector_spec.js:18335:1)\n at __webpack_require__
>>>> (regression/javascript/selection/column_selector_spec.js:20:30)\n
>>>> at regression/javascript/selection/column_selector_spec.js:63:18\n
>>>> at regression/javascript/selection/column_selector_spec.js:66:10"
>>>> }
>>>>
>>>> HeadlessChrome 0.0.0 (Windows 10 0.0.0) ERROR
>>>> {
>>>> "message": "Uncaught Error: SlickGrid requires jquery.event.drag
>>>> module to be loaded\nat regression/javascript/selectio
>>>> n/column_selector_spec.js:13842:3\n\nError: SlickGrid requires
>>>> jquery.event.drag module to be loaded\n at Object.<anonymous>
>>>> (regression/javascript/selection/column_selector_spec.js:13842:9)\n
>>>> at Object.5 (regression/javascript/selecti
>>>> on/column_selector_spec.js:17810:30)\n at __webpack_require__
>>>> (regression/javascript/selection/column_selector_spec.js:20:30)\n
>>>> at Object.904 (regression/javascript/selecti
>>>> on/column_selector_spec.js:18335:1)\n at __webpack_require__
>>>> (regression/javascript/selection/column_selector_spec.js:20:30)\n
>>>> at regression/javascript/selection/column_selector_spec.js:63:18\n
>>>> at regression/javascript/selection/column_selector_spec.js:66:10",
>>>> "str": "Uncaught Error: SlickGrid requires jquery.event.drag module
>>>> to be loaded\nat regression/javascript/selectio
>>>> n/column_selector_spec.js:13842:3\n\nError: SlickGrid requires
>>>> jquery.event.drag module to be loaded\n at Object.<anonymous>
>>>> (regression/javascript/selection/column_selector_spec.js:13842:9)\n
>>>> at Object.5 (regression/javascript/selecti
>>>> on/column_selector_spec.js:17810:30)\n at __webpack_require__
>>>> (regression/javascript/selection/column_selector_spec.js:20:30)\n
>>>> at Object.904 (regression/javascript/selecti
>>>> on/column_selector_spec.js:18335:1)\n at __webpack_require__
>>>> (regression/javascript/selection/column_selector_spec.js:20:30)\n
>>>> at regression/javascript/selection/column_selector_spec.js:63:18\n
>>>> at regression/javascript/selection/column_selector_spec.js:66:10"
>>>> }
>>>>
>>>> error Command failed with exit code 1.
>>>> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about
>>>> this command.
>>>> error Command failed with exit code 1.
>>>> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about
>>>> this command.
>>>>
>>>> Thanks.
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Attachment Content-Type Size
Win10JsTestFix.patch application/octet-stream 1.0 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2018-05-11 06:31:53 Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree
Previous Message Akshay Joshi 2018-05-11 06:23:54 Re: [pgAdmin4][Patch]: RM #3277 Runtime startup error handling is broken on Windows.