| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
| Cc: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
| Subject: | Re: JS Test error on Windows |
| Date: | 2018-05-11 09:35:28 |
| Message-ID: | CA+OCxowUyxDkSSAM7pqxpuxK3JQBvJ8NXKsTS95FGr7wkuuiSw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Fri, May 11, 2018 at 7:28 AM, Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi Dave/Hackers,
>
> PFA fix for the problem. The RegEx for webpack test is not working on
> windows because the path separator is different for Windows( \ ) and
> Unix( / ). And so, the imports loader is not executing for slickgrid.
> Patch tested on Win 10, Win 7, Ubuntu, Cent OS and works fine.
>
Nice catch! How did you figure that one out?
Patch applied.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aditya Toshniwal | 2018-05-11 09:53:49 | Re: JS Test error on Windows |
| Previous Message | Dave Page | 2018-05-11 09:23:41 | pgAdmin 4 commit: Fix webpack config regexps to be more Windows-friendl |