From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
---|---|
To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | [pgAdmin4][RM2927] Move all CSS into SCSS files for consistency and ease of colour maintenance etc. |
Date: | 2018-08-14 09:12:41 |
Message-ID: | CAM9w-_mRzOcEJ=kvq7oL-69GWPXGCLcJr7Sr=c5G04yn2R7Rmw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Hacker,
Attached is the patch to replace CSS with SCSS wherever needed. Highlights
of patch:
1) Use of globally defined colors and styles across the complete
application using SCSS.
2) Modularity in CSS - All the SCSS and CSS files in different modules will
be pulled for bundling automatically.
3) Remove hard coded hash codes in different JS files and use CSS class
instead.
4) Replace different out of the theme colors with colors defined in global
SCSS variables.
5) Removed '~bootstrap/dist/css/bootstrap-theme.css'. We dont need it
actually. This will bring default bootstrap design with less gradient use
(gradient kills performance)
Please note, there will be slight color differences from the original. I
have tried to cover most of the app but may have missed few, please point
out.
Also, it is mandatory for wcDocker to provide a theme. To stop it, we need
to change wcDocker code. So for now I have provided empty css file.
Kindly review.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
Attachment | Content-Type | Size |
---|---|---|
RM2927.patch | application/octet-stream | 251.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Ganesh Jaybhay | 2018-08-14 12:53:18 | [pgAdmin4][Patch] Rename DROP & DROP CASCADE in confirmation dialog title |
Previous Message | Ashesh Vashi | 2018-08-14 04:48:33 | pgAdmin 4 commit: Changed the icon, label, inode, etc. propely while re |