Re: pgAdmin4 form control error icon position change

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgAdmin4 form control error icon position change
Date: 2018-03-21 09:34:24
Message-ID: CAM9w-_kdah46=eY-UyvRFCdxujXu9o500MVrf+LUZSOw4eY1Zw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Created - https://redmine.postgresql.org/issues/3226

On Wed, Mar 21, 2018 at 2:51 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hello Aditya,
>
> Could you please create new RM
> <https://redmine.postgresql.org/projects/pgadmin4> for the issue, so that
> we can keep track of changes, It will be difficult for us to keep track
> of email for the details.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Wed, Mar 21, 2018 at 2:28 PM, Aditya Toshniwal <aditya.toshniwal@
> enterprisedb.com> wrote:
>
>>
>> *Hi Team,*
>>
>> This is regarding the position of error icon of a pgAdmin form control.
>> Below are the screenshots. As we can see, the error icon is overlapping the
>> control buttons like the drop down button, spinner up down buttons, etc.
>>
>>
>>
>>
>> We propose that we can move the error icon to the front of the label of
>> the form control. Below are screenshots.
>>
>>
>>
>>
>> Attached is the patch for the above changes.
>> Kindly review.
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions
>> Pune | Mob - 8055837949
>>
>
>

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions
Pune | Mob - 8055837949

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message pgAdmin 4 Jenkins 2018-03-21 09:37:21 Jenkins build is back to normal : pgadmin4-master-python36 #535
Previous Message Murtuza Zabuawala 2018-03-21 09:21:51 Re: pgAdmin4 form control error icon position change