From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
Cc: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: pgAdmin4 form control error icon position change |
Date: | 2018-03-23 09:57:53 |
Message-ID: | CA+OCxowkHXW0OTX18YmbVZnZcuLMpL4FTrwU2qAt+XcHAS4Eyw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks Aditya, patch applied.
On Wed, Mar 21, 2018 at 9:34 AM, Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Created - https://redmine.postgresql.org/issues/3226
>
>
> On Wed, Mar 21, 2018 at 2:51 PM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hello Aditya,
>>
>> Could you please create new RM
>> <https://redmine.postgresql.org/projects/pgadmin4> for the issue, so
>> that we can keep track of changes, It will be difficult for us to keep
>> track of email for the details.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> On Wed, Mar 21, 2018 at 2:28 PM, Aditya Toshniwal <
>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>
>>>
>>> *Hi Team,*
>>>
>>> This is regarding the position of error icon of a pgAdmin form control.
>>> Below are the screenshots. As we can see, the error icon is overlapping the
>>> control buttons like the drop down button, spinner up down buttons, etc.
>>>
>>>
>>>
>>>
>>> We propose that we can move the error icon to the front of the label of
>>> the form control. Below are screenshots.
>>>
>>>
>>>
>>>
>>> Attached is the patch for the above changes.
>>> Kindly review.
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB Software Solutions
>>> Pune | Mob - 8055837949 <(805)%20583-7949>
>>>
>>
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions
> Pune | Mob - 8055837949 <(805)%20583-7949>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Khushboo Vashi | 2018-03-23 09:57:59 | Re: v3.0 release on hold |
Previous Message | Dave Page | 2018-03-23 09:57:40 | pgAdmin 4 commit: Move the field error indicators in front of the affec |