Re: Pgadmin4 System Stats Extension Design

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: Sahil Harpal <sahilharpal1234(at)gmail(dot)com>
Cc: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Pgadmin4 System Stats Extension Design
Date: 2023-08-25 06:00:06
Message-ID: CAM9w-_kEePXiF1HFu_9uLEaAWbcqX43wJpF8RQMkzXQu6QB-9w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Sahil,

On Thu, Aug 24, 2023 at 8:28 PM Sahil Harpal <sahilharpal1234(at)gmail(dot)com>
wrote:

> On Sat, 19 Aug 2023 at 16:20, Sahil Harpal <sahilharpal1234(at)gmail(dot)com>
> wrote:
>
>> On Thu, 17 Aug 2023 at 17:57, Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>>
>>> - Sometimes graphs start from left and then shift to right. This
>>> issue I have reported in my initial review too.
>>>
>>> For StreamingChart should I ignore it for now?
>> On Mon, 7 Aug 2023 at 17:12, Aditya Toshniwal <
>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>
>>> OK I thought you wanted the graph to go from left to right. Yeah, I
>>> have seen that glitch a few times (but rare). I think you can ignore it for
>>> now, we can look into it once we get time. It is not a priority.
>>>
>>
>> Or try the solution below?
>> On Sun, 6 Aug 2023 at 13:21, Sahil Harpal <sahilharpal1234(at)gmail(dot)com>
>> wrote:
>>
>>> I've tried one more approach here. If our data array is full, this graph
>>> shifting won't happen. So, if we initialize our data list with null values,
>>> there won't be any visible shift. What do you think about this solution?
>>>
>> Can you please help me with this?
>
Let me apply your patch and try once.

--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
<https://www.enterprisedb.com/>
"Don't Complain about Heat, Plant a TREE"

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2023-08-25 06:25:41 Re: Pgadmin4 System Stats Extension Design
Previous Message Aditya Toshniwal 2023-08-25 05:59:00 Re: Pgadmin4 System Stats Extension Design