Re: Pgadmin4 System Stats Extension Design

Hi Sahil,

On Fri, Aug 25, 2023 at 11:30 AM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Sahil,
>
> On Thu, Aug 24, 2023 at 8:28 PM Sahil Harpal <sahilharpal1234(at)gmail(dot)com>
> wrote:
>
>> On Sat, 19 Aug 2023 at 16:20, Sahil Harpal <sahilharpal1234(at)gmail(dot)com>
>> wrote:
>>
>>> On Thu, 17 Aug 2023 at 17:57, Khushboo Vashi <
>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>>
>>>> - Sometimes graphs start from left and then shift to right. This
>>>> issue I have reported in my initial review too.
>>>>
>>>> For StreamingChart should I ignore it for now?
>>> On Mon, 7 Aug 2023 at 17:12, Aditya Toshniwal <
>>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>>
>>>> OK I thought you wanted the graph to go from left to right. Yeah, I
>>>> have seen that glitch a few times (but rare). I think you can ignore it for
>>>> now, we can look into it once we get time. It is not a priority.
>>>>
>>>
>>> Or try the solution below?
>>> On Sun, 6 Aug 2023 at 13:21, Sahil Harpal <sahilharpal1234(at)gmail(dot)com>
>>> wrote:
>>>
>>>> I've tried one more approach here. If our data array is full, this
>>>> graph shifting won't happen. So, if we initialize our data list with null
>>>> values, there won't be any visible shift. What do you think about this
>>>> solution?
>>>>
>>> Can you please help me with this?
>>
> Let me apply your patch and try once.
>
Can you please share the rebased patch?

>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
> <https://www.enterprisedb.com/>
> "Don't Complain about Heat, Plant a TREE"
>

--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
<https://www.enterprisedb.com/>
"Don't Complain about Heat, Plant a TREE"