Re: [pgAdmin4][RM3657] Query Tool ignores Auto Commit setting and misinforms current mode in the UI

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][RM3657] Query Tool ignores Auto Commit setting and misinforms current mode in the UI
Date: 2018-09-19 13:13:09
Message-ID: CAM9w-_=yY5Ff0Ouxzd7+yMs8BzfGLd2HrfZfk8ukX6EyKRgaiA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Attached is the updated patch. Kindly review.

On Wed, Sep 19, 2018 at 6:20 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Please hold on. Need to fix some PEP8 issues. :|
>
> On Wed, Sep 19, 2018 at 6:07 PM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Attached is patch to fix auto commit issue where changing auto commit
>> option from preferences was not having any effect in query tools.
>>
>> Kindly review.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

Attachment Content-Type Size
RM3657.patch application/octet-stream 4.4 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2018-09-19 15:50:15 pgAdmin 4 commit: Ensure changes to Query Tool settings from the Prefer
Previous Message Aditya Toshniwal 2018-09-19 12:50:08 Re: [pgAdmin4][RM3657] Query Tool ignores Auto Commit setting and misinforms current mode in the UI