Re: [pgAdmin4][RM3657] Query Tool ignores Auto Commit setting and misinforms current mode in the UI

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][RM3657] Query Tool ignores Auto Commit setting and misinforms current mode in the UI
Date: 2018-09-19 15:51:02
Message-ID: CA+OCxoxjSmuDVXY_rtffaaYrqj=rxKessed3i-=mv7+vJ_NhBQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied!

On Wed, Sep 19, 2018 at 2:13 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Attached is the updated patch. Kindly review.
>
> On Wed, Sep 19, 2018 at 6:20 PM Aditya Toshniwal <
> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please hold on. Need to fix some PEP8 issues. :|
>>
>> On Wed, Sep 19, 2018 at 6:07 PM Aditya Toshniwal <
>> aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is patch to fix auto commit issue where changing auto commit
>>> option from preferences was not having any effect in query tools.
>>>
>>> Kindly review.
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> Software Engineer | EnterpriseDB Software Solutions | Pune
>>> "Don't Complain about Heat, Plant a tree"
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions | Pune
>> "Don't Complain about Heat, Plant a tree"
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message pgAdmin 4 Jenkins 2018-09-19 16:03:40 Build failed in Jenkins: pgadmin4-master-python33 #762
Previous Message Dave Page 2018-09-19 15:50:15 pgAdmin 4 commit: Ensure changes to Query Tool settings from the Prefer