Re: Query Tool Fix

From: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
To: Yosry Muhammad <yosrym93(at)gmail(dot)com>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Query Tool Fix
Date: 2019-07-31 05:05:04
Message-ID: CAM9w-_=Pd3wzRCdQ2sVBZqMW5oASOjoyjP5bN2a9e3CJ0+dT2A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Yosry,

The changes to fix 4520 are in python side. I would suggest if you can
separate it out from this patch, so that we can ask the users(affected by
4520) to just replace the python files in their installed pgAdmin4. This
fix will not be available till next release, but we can give the workaround
files. Most users are unable to upgrade psycopg2 on their systems.

On Tue, Jul 30, 2019 at 8:10 PM Yosry Muhammad <yosrym93(at)gmail(dot)com> wrote:

> Hi,
>
> Please find attached a patch with the following bug fixes for the query
> tool:
> - View data not working correctly when the table/view does not contain any
> columns (#4492).
> - Query tool does not produce results when psycopg2 version is below 2.8
> (#4520).
> - Command tags and number of affected rows not shown in the query result
> messages (#4525 and #4529 - duplicates).
>
> Note that:
> #4524 and #4522 are feature requests for already existing features.
>
> Please review !
> Thanks
>
>
> --
> *Yosry Muhammad Yosry*
>
> Computer Engineering student,
> The Faculty of Engineering,
> Cairo University (2021).
> Class representative of CMP 2021.
> https://www.linkedin.com/in/yosrym93/
>

--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2019-07-31 10:39:47 [RM#4546] Add RE-SQL tests for Column node
Previous Message Yosry Muhammad 2019-07-30 14:40:22 Query Tool Fix