Re: Query Tool Fix

Hi

On Wed, Jul 31, 2019 at 6:05 AM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Yosry,
>
> The changes to fix 4520 are in python side. I would suggest if you can
> separate it out from this patch, so that we can ask the users(affected by
> 4520) to just replace the python files in their installed pgAdmin4. This
> fix will not be available till next release, but we can give the workaround
> files. Most users are unable to upgrade psycopg2 on their systems.
>

Agreed. As a general rule, we try to keep to one fix per patch/commit as it
makes it much easier to understand changes, especially after some time.
Having a stated dependency between patches is fine if that's necessary.

Can you split the changes up please?

Thanks.

>
> On Tue, Jul 30, 2019 at 8:10 PM Yosry Muhammad <yosrym93(at)gmail(dot)com> wrote:
>
>> Hi,
>>
>> Please find attached a patch with the following bug fixes for the query
>> tool:
>> - View data not working correctly when the table/view does not contain
>> any columns (#4492).
>> - Query tool does not produce results when psycopg2 version is below 2.8
>> (#4520).
>> - Command tags and number of affected rows not shown in the query result
>> messages (#4525 and #4529 - duplicates).
>>
>> Note that:
>> #4524 and #4522 are feature requests for already existing features.
>>
>> Please review !
>> Thanks
>>
>>
>> --
>> *Yosry Muhammad Yosry*
>>
>> Computer Engineering student,
>> The Faculty of Engineering,
>> Cairo University (2021).
>> Class representative of CMP 2021.
>> https://www.linkedin.com/in/yosrym93/
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company