Re: [pgAdmin4][Patch]: RM1683 - Reverse engineered SQL for function ALTERs/ACLs is incorrect with OUT parameters

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM1683 - Reverse engineered SQL for function ALTERs/ACLs is incorrect with OUT parameters
Date: 2016-09-12 10:24:10
Message-ID: CAM5-9D_mXq9y15EysJwCsk5wsTXtr+trcNv4upzMKTp3ruSrGw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

This patch doesn't fix the issue in Procedure node. I will send updated
patch.

On Mon, Sep 12, 2016 at 3:12 PM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Please find attached patch with fix.
> *Changes:*
> 1) Take a list of "function argument types", create a string separated by
> comma(removing trailing comma).
> 2) Function arguments in ALTER and GRANT not necessarily to have *argument
> mode, name, *they are optional. Only type is required.
> Now GRANT statement is represented as
>
> *GRANT EXECUTE ON FUNCTION test_schema.test_func(integer, integer,
> integer) TO postgres *as in pgadmin3.
>
>
> Please review.
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-09-12 10:37:40 pgAdmin 4 commit: Prevent creation of packages and rules in catalogs. F
Previous Message Surinder Kumar 2016-09-12 09:42:22 [pgAdmin4][Patch]: RM1683 - Reverse engineered SQL for function ALTERs/ACLs is incorrect with OUT parameters