Re: [pgAdmin4][Patch]: RM#1268 - Add a Help button to the bottom left of the Wizard framework

On Wed, Jun 8, 2016 at 6:40 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> On Wed, Jun 8, 2016 at 1:55 PM, Surinder Kumar
> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> >
> >
> > On Wed, Jun 8, 2016 at 6:15 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> >>
> >> On Wed, Jun 8, 2016 at 1:41 PM, Surinder Kumar
> >> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> >> > On Wed, Jun 8, 2016 at 6:07 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> >> >>
> >> >> Hi
> >> >>
> >> >> On Tue, Jun 7, 2016 at 9:44 AM, Surinder Kumar
> >> >> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> >> >> > Hi,
> >> >> >
> >> >> > Please find the patch with following changes:
> >> >> > 1. Added help button to the bottom left of the wizard framework.
> >> >> > Usage:
> >> >> > Set wizard_help property with url while creating wizard object.
> >> >> >
> >> >> > var wizard = new (pgBrowser.Wizard.extend({
> >> >> > options: {
> >> >> > title: _('Wizard Title'),
> >> >> > wizard_help: "{{ url_for('help.static',
> >> >> > filename='grant_wizard.html')
> >> >> > }}"
> >> >> > }
> >> >> > })
> >> >> >
> >> >> > 2. Previously wizard progress bar was in bottom left of the wizard
> >> >> > framework
> >> >> > in place of help button.
> >> >> > So, It is now moved to top of Wizard page.
> >> >> >
> >> >> > 3. Added class col-xs-* to the wizard div to be more consistent.
> >> >> >
> >> >> > 4. Set proper height for wizard-right-panel_content in css.
> >> >>
> >> >> Is part of the patch missing? The only visible changes I see are that
> >> >> the buttons are now misaligned (see attached) - note that it's only
> on
> >> >> the first page, and only when first opened. There's no sign of a help
> >> >> button.
> >> >
> >> > Can you please attach screenshot ?
> >>
> >> Sorry :-)
> >>
> >> BTW, Chrome 50.0 on OS X 10.11.
> >
> > It looks to me same as in screenshot when I opened grant wizard on
> Firefox.
> > But after clearing the browser cache, it shows help button.
> > please try after clearing cache. if issue still persist let me know.
>
> Hmm, we probably need to figure out a way to fix that - end users are
> likely to have issues following upgrades (shift+reload doesn't work -
> it really does need a cache clear).
>
> OK, I've committed the patch as-is, however the fact that the Wizard
> is modal is still a problem because the user cannot read the help
> without closing the wizard. Can you fix that please?
>
yes, I will send the patch to make grant wizard non-modal.

>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>