[pgAdmin4][Patch]: Node issues under catalogs

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin4][Patch]: Node issues under catalogs
Date: 2016-05-25 14:14:44
Message-ID: CAM5-9D_6mUo_gYJugiTYaXkR920-6YwJCAZAHAUc2e=CB12FqQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

Following are the issues fixed in this patch:
1. Nodes not expanding under catalogs
*Issue: *Check for setting schema was missing. schema should set only if
node is in create mode.

2. Error fetching node's properties.
*Issue: *Node attribute *parent_type* is not set to catalogs.

3. Don't show create rule option in table create menu if it is under
catalog.

4. Security tab of node should be hidden under catalogs.
Every node with controls *privilege and security labels* must be under *type:
group*
to keep them hide when node is listed under catalogs.
This code is implemented in backform.pgadmin.js

*For Example:*

*schema:[*{
id: '*security*', label: '{{ _("Security") }}',
*type: 'group'*
},{
id: 'acl', label: '{{ _('Privileges') }}', *group: '{{ _('security') }}'*
},{
id: 'seclabels', label: '{{ _('Security Labels') }}',
model: SecurityModel, type: 'collection',
*group: '{{ _('security') }}'*
}*]*

Please find attached patch and review.

Thanks,
Surinder Kumar

Attachment Content-Type Size
node_issues_under_catalogs.patch application/octet-stream 29.6 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Susan Douglas 2016-05-25 14:25:44 Documentation patch for pgAdmin 4
Previous Message Ashesh Vashi 2016-05-25 12:28:43 Re: [pgAdmin4][datagrid] : Fix URL generation issue in datagrid