From: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch]: Node issues under catalogs |
Date: | 2016-05-26 03:28:33 |
Message-ID: | CAG7mmow8WwA-RhbvYaDh7eOn7+iqYasea0HxoQwjpLz2eRH4Aw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Wed, May 25, 2016 at 7:44 PM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi
>
> Following are the issues fixed in this patch:
> 1. Nodes not expanding under catalogs
> *Issue: *Check for setting schema was missing. schema should set only if
> node is in create mode.
>
> 2. Error fetching node's properties.
> *Issue: *Node attribute *parent_type* is not set to catalogs.
>
Please share a separate patch for above fixes.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com/>
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>
>
> 3. Don't show create rule option in table create menu if it is under
> catalog.
>
> 4. Security tab of node should be hidden under catalogs.
> Every node with controls *privilege and security labels* must be under *type:
> group*
> to keep them hide when node is listed under catalogs.
> This code is implemented in backform.pgadmin.js
>
> *For Example:*
>
> *schema:[*{
> id: '*security*', label: '{{ _("Security") }}',
> *type: 'group'*
> },{
> id: 'acl', label: '{{ _('Privileges') }}', *group: '{{ _('security')
> }}'*
> },{
> id: 'seclabels', label: '{{ _('Security Labels') }}',
> model: SecurityModel, type: 'collection',
> *group: '{{ _('security') }}'*
> }*]*
>
> Please find attached patch and review.
>
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Surinder Kumar | 2016-05-26 03:58:41 | Re: [pgAdmin4][Patch]: Node issues under catalogs |
Previous Message | Ashesh Vashi | 2016-05-26 03:27:13 | Re: [pgAdmin4][Patch]: Node issues under catalogs |