[pgAdmin4][Patch]: Background process executor won't run(in case of Backup, restore) in Windows only

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin4][Patch]: Background process executor won't run(in case of Backup, restore) in Windows only
Date: 2016-09-21 10:48:15
Message-ID: CAM5-9D_+dUN79tJoK35Vq2oXLybeBwVFPFKHmF5NPKg6HR_c3Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

While working on RM*1391 *I found another issue* 'Backup is not working on
windows".*

The reason is that the process executor which uses subprocess Popen() to
execute job fails when we pass close_fds=True and shell=False in windows.

Now we are settings close_fds=False and shell=True to fix it. These
settings are specific to windows only.

Please review the attached patch.

Thanks,
Surinder Kumar

Attachment Content-Type Size
process_executor_not_running_in_win.patch application/octet-stream 3.0 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Navnath Gadakh 2016-09-21 11:16:08 Re: Regression errors - database node
Previous Message Murtuza Zabuawala 2016-09-21 10:43:27 PATCH: To fix JSON array handling (pgAdmin4)