From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch]: Background process executor won't run(in case of Backup, restore) in Windows only |
Date: | 2016-09-22 13:05:29 |
Message-ID: | CA+OCxoziDJ602ijijUsVDOgP8jwHpqpKMBxXeY_9amcE_4bUOg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Can you explain what was broken exactly please? Backups work fine for
me without the patch - and whilst they also work with it, I now get an
ugly command shell window flash up which I didn't before.
On Wed, Sep 21, 2016 at 11:48 AM, Surinder Kumar
<surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi
>
> While working on RM1391 I found another issue 'Backup is not working on
> windows".
>
> The reason is that the process executor which uses subprocess Popen() to
> execute job fails when we pass close_fds=True and shell=False in windows.
>
> Now we are settings close_fds=False and shell=True to fix it. These settings
> are specific to windows only.
>
> Please review the attached patch.
>
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Murtuza Zabuawala | 2016-09-22 13:08:39 | PATCH: Adding support of Package in synonym (pgAdmin4) |
Previous Message | Murtuza Zabuawala | 2016-09-22 12:16:09 | Re: PATCH: To fix the issue with stats table in PG9.6 (pgAdmin4) |