| From: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values |
| Date: | 2017-05-10 08:52:01 |
| Message-ID: | CAM5-9D9JdEim47AnTVKKhqOBJsbxoO+ufwE7FtPya9HmC6j8Zg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Dave,
Please find attached patch for RM only.
*Changes:*
- All formatters now handles both [null] and [default] values
- the cell values are validated on server side as in pgAdmin3.
- added light grey color for cells with [null] and [default] placeholders.
On Wed, May 10, 2017 at 2:12 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>
> On Wed, May 10, 2017 at 9:39 AM, Surinder Kumar <
> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave,
>>
>> On Wed, May 10, 2017 at 2:06 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Any chance we can get this wrapped up today Surinder?
>>>
>> I have fixed RM case, I am currently writing its feature test cases
>> which is taking some time.
>> Should I send patch for RM case only? I will try to complete test cases
>> by today eod.
>>
>
> Yes please.
>
> Thanks!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
| Attachment | Content-Type | Size |
|---|---|---|
| RM_2257_v3.patch | application/octet-stream | 13.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | pgAdmin 4 Jenkins | 2017-05-10 08:59:15 | Build failed in Jenkins: pgadmin4-master-python33 #103 |
| Previous Message | Dave Page | 2017-05-10 08:48:38 | Re: [pgAdmin4][PATCH] To fix the of issue in Trigger node |