Re: [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values

Hi Dave,

Please find attached patch for Feature test cases for RM_2257

*Implementation detail:*

- Added a test_data.json file which contains Insert and Update test
related input data

- First of all, we create three tables such as
a) defaults_text
b) defaults_boolean
c) defaults_number
d) defaults_json
These tables has columns with different constraints (default value,
not_null etc) to test with various input test data.

- Test cases for insert are executed first and then test cases for update.

Please review the patch.

On Wed, May 10, 2017 at 2:22 PM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:

> Hi Dave,
>
> Please find attached patch for RM only.
>
> *Changes:*
>
> - All formatters now handles both [null] and [default] values
>
> - the cell values are validated on server side as in pgAdmin3.
>
> - added light grey color for cells with [null] and [default] placeholders.
>
> On Wed, May 10, 2017 at 2:12 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>>
>>
>> On Wed, May 10, 2017 at 9:39 AM, Surinder Kumar <
>> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Dave,
>>>
>>> On Wed, May 10, 2017 at 2:06 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> Any chance we can get this wrapped up today Surinder?
>>>>
>>> ​I have fixed RM case, I am currently writing its feature test cases
>>> which is taking some time.
>>> Should I send patch for RM case only?​ I will try to complete test cases
>>> by today eod.
>>>
>>
>> Yes please.
>>
>> Thanks!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>