| From: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: RM2039 - Big (numeric) numbers are sometimes rounded up when displayed |
| Date: | 2017-02-24 12:35:40 |
| Message-ID: | CAM5-9D9EB1dvXMbP9Am77b_T_-P1ETwjz=Lu4G-8WamFwKfikg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Dave,
Please find updated patch.
*Changes:*
1) Add typecaster for numeric and double precision.
2) As numeric data is typecasted into string type, we need not to do
parseInt value in javascript.
3) Remove redundant code for registering new types.
On Mon, Jan 9, 2017 at 9:11 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Hi
>
> On Friday, December 23, 2016, Surinder Kumar <
> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Added 'numeric' type into string typecaster to prevent python from
>> rounded up.
>>
>> Please find attached patch and review.
>>
>
> I'm still seeing rounding with this patch applied - e.g. with:
>
> select 12345678901234567890::numeric
>
> Something in the JS perhaps?
>
>
>
| Attachment | Content-Type | Size |
|---|---|---|
| RM2039_v2.patch | application/octet-stream | 3.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2017-02-24 12:42:28 | pgAdmin 4 commit: Fix function arguments when generating create SQL. Fi |
| Previous Message | Dave Page | 2017-02-24 12:21:29 | Re: [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing |