Re: [pgAdmin4][Patch]: RM2039 - Big (numeric) numbers are sometimes rounded up when displayed

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM2039 - Big (numeric) numbers are sometimes rounded up when displayed
Date: 2017-02-24 13:39:55
Message-ID: CA+OCxozKM4jJtLjOtv4iDvV8L3DanBNewasgC4vFbdHtLmoFvQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, patch applied.

On Fri, Feb 24, 2017 at 12:35 PM, Surinder Kumar
<surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> Please find updated patch.
>
> Changes:
>
> 1) Add typecaster for numeric and double precision.
>
> 2) As numeric data is typecasted into string type, we need not to do
> parseInt value in javascript.
>
> 3) Remove redundant code for registering new types.
>
>
> On Mon, Jan 9, 2017 at 9:11 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> Hi
>>
>> On Friday, December 23, 2016, Surinder Kumar
>> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>>
>>> Hi,
>>>
>>> Added 'numeric' type into string typecaster to prevent python from
>>> rounded up.
>>>
>>> Please find attached patch and review.
>>
>>
>> I'm still seeing rounding with this patch applied - e.g. with:
>>
>> select 12345678901234567890::numeric
>>
>> Something in the JS perhaps?
>>
>>
>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-02-24 13:47:40 pgAdmin 4 commit: Fix display of boolean nulls in the query tool. Fixes
Previous Message Dave Page 2017-02-24 13:39:43 pgAdmin 4 commit: Fix display of long integers and decimals. Fixes #203