| From: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: Stop Flask from initialising service twice in Debug mode |
| Date: | 2017-07-21 07:27:21 |
| Message-ID: | CAM5-9D95RiheEDW_LnzGryiQpoS0Xjf3Qbs8QYkBn-bGfa2W_Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi
In this patch, i have added reference to the implementation.
Please find updated patch and review.
Thanks,
Surinder
On Fri, Jul 21, 2017 at 12:32 PM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi
>
> When pgAdmin4 runs in DEBUG mode, Flask initialise service twice, while in
> non-DEBUG mode, once. It is pain while development because `yarn run
> bundle` also runs twice.
>
> It is because the parameter `use_reloader` = True in Debug Mode.
>
> If `os.environ` variable `WERKZEUG_RUN_MAIN` is set to None, i.e. app is
> starting for the first time and then its value is changed to True.
>
> Please find attached patch.
>
> Thanks
> Surinder
>
>
>
>
| Attachment | Content-Type | Size |
|---|---|---|
| start_flask_service_once_in_debug_mode_v1.patch | application/octet-stream | 928 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Surinder Kumar | 2017-07-21 07:43:57 | [pgAdmin4][Patch]: Using editorconfig to maintain consistent coding styles between different IDE's |
| Previous Message | Surinder Kumar | 2017-07-21 07:02:39 | [pgAdmin4][Patch]: Stop Flask from initialising service twice in Debug mode |