From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch]: Stop Flask from initialising service twice in Debug mode |
Date: | 2017-07-21 08:47:33 |
Message-ID: | CA+OCxozbwH1sa2bwpXMoR+RXeiVzE_XJSt0katGx_CSDchu1=Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, applied. The reloader has always been a little temperamental for
me, so I couldn't prove this doesn't break it. If someone finds it does,
please yelp.
On Fri, Jul 21, 2017 at 8:27 AM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi
>
> In this patch, i have added reference to the implementation.
> Please find updated patch and review.
>
> Thanks,
> Surinder
>
> On Fri, Jul 21, 2017 at 12:32 PM, Surinder Kumar <
> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>
>> Hi
>>
>> When pgAdmin4 runs in DEBUG mode, Flask initialise service twice, while
>> in non-DEBUG mode, once. It is pain while development because `yarn run
>> bundle` also runs twice.
>>
>> It is because the parameter `use_reloader` = True in Debug Mode.
>>
>> If `os.environ` variable `WERKZEUG_RUN_MAIN` is set to None, i.e. app is
>> starting for the first time and then its value is changed to True.
>>
>> Please find attached patch.
>>
>> Thanks
>> Surinder
>>
>>
>>
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2017-07-21 08:54:28 | Re: [pgadmin4][PATCH] Query History Arrow Navigation and Styling |
Previous Message | Dave Page | 2017-07-21 08:46:35 | pgAdmin 4 commit: Prevent the Werkzeug reloader from causing a "double |