From: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
---|---|
To: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Dave Page <dpage(at)pgadmin(dot)org> |
Subject: | Re: pgAdmin 4 commit: Fix query tool horizontal scrolling of results. Fixes |
Date: | 2016-06-15 07:21:12 |
Message-ID: | CAM5-9D95HJWyXufQO0fcTn9guPDxdkuLXpmOCx8fW9PguhGv=A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Ashesh,
I have revert back the changes made in backgrid-sizeable.css and override
the table.backgrid css of resizable in overrides.css.
Please find the patch and review.
On Wed, Jun 15, 2016 at 10:42 AM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> OK, I will fix it.
>
> On Wed, Jun 15, 2016 at 10:41 AM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> On Tue, Jun 14, 2016 at 8:21 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Fix query tool horizontal scrolling of results. Fixes #1362
>>>
>>> The backgrid-sizeable's css property 'overflow: hidden' was overriding
>>> backgrid table css property and It was reproducible only in runtime.
>>> Removed 'overflow: hidden' property from backgrid-sizeabled-columns.css
>>>
>>> Branch
>>> ------
>>> master
>>>
>>> Details
>>> -------
>>>
>>> http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e881695050b8ba4cf99b365ff2c0f4e02d03ced6
>>> Author: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
>>>
>>> Modified Files
>>> --------------
>>> web/pgadmin/static/css/backgrid/backgrid-sizeable-columns.css | 1 -
>>>
>> This is not correct place to handle the issue.
>>
>> We should not change third party CSS.
>> We should handle this issue in override.css.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com/>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi>
>>
>>
>>> web/pgadmin/static/js/backform.pgadmin.js | 5 +----
>>> 2 files changed, 1 insertion(+), 5 deletions(-)
>>>
>>>
>>> --
>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>> To make changes to your subscription:
>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>
>>
>>
>
Attachment | Content-Type | Size |
---|---|---|
RM#1362_v1.patch | application/octet-stream | 866 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-06-15 08:39:03 | Re: pgAdmin IV API test cases patch |
Previous Message | Murtuza Zabuawala | 2016-06-15 07:06:59 | Re: PATCH: Added Statistics functionality for many nodes (pgAdmin4) |