From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Priyanka Shendge <priyanka(dot)shendge(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Kanchan Mohitey <kanchan(dot)mohitey(at)enterprisedb(dot)com> |
Subject: | Re: pgAdmin IV API test cases patch |
Date: | 2016-06-15 08:39:03 |
Message-ID: | CA+OCxoyqfK8pUGGmeO=5pyC=MOizNMOnfshAfgQ5NjMRnkjgmA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi
On Thu, Jun 9, 2016 at 1:37 PM, Priyanka Shendge
<priyanka(dot)shendge(at)enterprisedb(dot)com> wrote:
> Hi Dave,
>
> PFA updated patch. I have made changes suggested by you.
>
> Kindly, review and let me know for more changes.
OK, I got a bit further this time, but not there yet.
1) The patch overwrote my test_config.json file. That should never
happen (that file shouldn't be in the source tree).
test_config.json.in should be the file that's included in the patch.
2) The updated test_config.json file is huge. I should only need to
define one or more connections, then be able to run the tests. If you
need to keep configuration info for "advanced users", let's put it in
a different file to avoid confusing/scaring everyone else. Maybe split
it into config.json for the stuff the user needs to edit
(config.json.in would go in git), and test_config.json for the test
configuration.
3) It fails on my machine, for what looks like a coding error
initially, then a lot of issues where it can't find parent_id.pkl.
I've attached the log.
Thanks.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment | Content-Type | Size |
---|---|---|
logger.log | application/octet-stream | 258.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-06-15 08:40:05 | Re: pgAdmin IV API test cases patch |
Previous Message | Surinder Kumar | 2016-06-15 07:21:12 | Re: pgAdmin 4 commit: Fix query tool horizontal scrolling of results. Fixes |