| From: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | [pgAdmin4][Patch]: Wrong listing of directories in File Manager in Windows Only. |
| Date: | 2016-09-05 09:51:19 |
| Message-ID: | CAM5-9D9+eq8auZ9SVOhU12xtTy29YaGSHitHfyTNfXocTK+gdw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi
*Issue:*
FileManager: when Select File dialog is opened in query tool in Runtime
Mode, it was listing wrong directory. instead it should list drives such as
C:\, D:\, E:\ etc if no STORAGE_DIR path is set in config_local.py. This is
a regression of RM 1937.
*Solution:*
we do list drives, If platform is Windows and If self.dir is set to None,
but self.dir is set to empty string inside __init__ constructor. This is
the reason it wasn't listing drives.
I have taken care it in this patch and tested it for following platforms:
Windows,
Ubuntu and
Mac.
Please find attached patch and review.
Thanks,
Surinder Kumar
| Attachment | Content-Type | Size |
|---|---|---|
| FileManager_show_drives_windows.patch | application/octet-stream | 2.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Murtuza Zabuawala | 2016-09-05 14:31:15 | PATCH: Added user confirmation on panel close (pgAdmin4) |
| Previous Message | Dave Page | 2016-09-05 08:30:05 | Re: pgAdmin 4 as Web application |