From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch]: Wrong listing of directories in File Manager in Windows Only. |
Date: | 2016-09-05 16:07:32 |
Message-ID: | CA+OCxoxxtk-eQD8iKwbrMwMgX8EKtckEJbYGxNcVD5tzShpm2Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, applied.
On Mon, Sep 5, 2016 at 10:51 AM, Surinder Kumar
<surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi
>
> Issue:
> FileManager: when Select File dialog is opened in query tool in Runtime
> Mode, it was listing wrong directory. instead it should list drives such as
> C:\, D:\, E:\ etc if no STORAGE_DIR path is set in config_local.py. This is
> a regression of RM 1937.
>
> Solution:
> we do list drives, If platform is Windows and If self.dir is set to None,
> but self.dir is set to empty string inside __init__ constructor. This is the
> reason it wasn't listing drives.
> I have taken care it in this patch and tested it for following platforms:
> Windows,
> Ubuntu and
> Mac.
>
> Please find attached patch and review.
>
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-09-05 16:18:47 | pgAdmin 4 commit: Warn the user about unsaved changes to SQL or data be |
Previous Message | Dave Page | 2016-09-05 16:07:12 | pgAdmin 4 commit: Fix file navigator to properly show drives in Windows |