[pgAdmin4][Patch]: Use standalone modules prop-types as React.PropTypes has moved into a different package since React v15.5

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin4][Patch]: Use standalone modules prop-types as React.PropTypes has moved into a different package since React v15.5
Date: 2017-09-18 05:28:31
Message-ID: CAM5-9D8p0DvRMFNDXJOfuUxQQO-DT0Y07p2wzMKe9qtBvSq7Pw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

While looking into a React bug, I tried running pgAdmin4 code with
Reactv15.5 or with Reactv16-RC-3, the code fails to run.
Because React's PropTypes is no more part of React Module. Reference link
<https://github.com/facebook/react/blob/master/CHANGELOG.md#user-content-1550-april-7-2017>
.

Please find an attached patch.

Thanks,
Surinder

Attachment Content-Type Size
fix_react_proptypes_deprecated.patch application/octet-stream 4.3 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Surinder Kumar 2017-09-18 05:46:25 [pgAdmin4][Patch]: Properly handle builtins.SERVER_MODE variable when SERVER_MODE is not set
Previous Message Ashesh Vashi 2017-09-17 19:35:22 pgAdmin 4 commit: Extending the tools, and miscellaneous javascript mod