Re: [pgAdmin4][Patch]: Use standalone modules prop-types as React.PropTypes has moved into a different package since React v15.5

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: Use standalone modules prop-types as React.PropTypes has moved into a different package since React v15.5
Date: 2017-09-18 09:08:38
Message-ID: CA+OCxoykfCAC6qShJ1RKtTqbko3D9-LZPnY2QCSRs1Po=nr8rw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks, applied.

On Mon, Sep 18, 2017 at 6:28 AM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:

> Hi
>
> While looking into a React bug, I tried running pgAdmin4 code with
> Reactv15.5 or with Reactv16-RC-3, the code fails to run.
> Because React's PropTypes is no more part of React Module. Reference link
> <https://github.com/facebook/react/blob/master/CHANGELOG.md#user-content-1550-april-7-2017>
> .
>
> Please find an attached patch.
>
> Thanks,
> Surinder
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2017-09-18 09:26:35 pgAdmin 4 commit: Replace the "Roboto" font family with "Open Sans" for
Previous Message Dave Page 2017-09-18 09:08:14 pgAdmin 4 commit: Support React v15.5 and later where the code fails to