| From: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl |
| Date: | 2016-04-29 06:04:23 |
| Message-ID: | CAM5-9D8hpNUTdYG_xqTLw7YxjynnNLM+niEgOd3gOab0G3Ry6g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi,
More specifically to the issue.
I am using SqlFieldControl in View for Definition Field which takes default
height of 300px which is set by Control as default height. but as per
dave's suggestion on thread
"The Definition box on the View dialogue should start at a single
line and expand as needed - see the Function dialogue".
If user still need some height for control, It can be specified in*
extraclasses[]* parameter which will apply to the specific field.
On Thu, Apr 28, 2016 at 7:02 PM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi,
>
> The *SqlFieldControl* is setting default height for textarea, which is
> not needed.
> It should expand as needed as similar in *SqlTabControl*.
>
> Please find the attached patch, review it.
>
> Thanks
> Surinder Kumar
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Harshal Dhumal | 2016-04-29 06:22:19 | Minor issues |
| Previous Message | Harshal Dhumal | 2016-04-28 14:22:30 | Re: [PATCH] Tables node (pgAdmin4) |