Re: [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>, Arun Kollan <arun(dot)kollan(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl
Date: 2016-04-29 10:36:49
Message-ID: CAG7mmozwV51hVVPpNx5A6Q184bMvvdbE-iC6FSO-A1oL2J6iEw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks - committed!

Thanks Arun for the quick review!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

On Fri, Apr 29, 2016 at 11:34 AM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:

> Hi,
>
> More specifically to the issue.
> I am using SqlFieldControl in View for Definition Field which takes
> default height of 300px which is set by Control as default height. but as
> per dave's suggestion on thread
>
>
> http://www.postgresql.org/message-id/CA+OCxozN++8sFqJwJZ5QSFBxa7p-47apohOLtSotPBK6N5vUJA@mail.gmail.com
>
> "The Definition box on the View dialogue should start at a single
> line and expand as needed - see the Function dialogue".
>
> If user still need some height for control, It can be specified in*
> extraclasses[]* parameter which will apply to the specific field.
>
>
>
> On Thu, Apr 28, 2016 at 7:02 PM, Surinder Kumar <
> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> The *SqlFieldControl* is setting default height for textarea, which is
>> not needed.
>> It should expand as needed as similar in *SqlTabControl*.
>>
>> Please find the attached patch, review it.
>>
>> Thanks
>> Surinder Kumar
>>
>
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2016-04-29 10:49:39 pgAdmin 4 commit: Show the resize handle on the alertify dialog.
Previous Message Ashesh Vashi 2016-04-29 10:36:15 pgAdmin 4 commit: Remove unnecessary extra classes set in the SqlFieldC