[pgAdmin3][Extension]: Wrong SQL generated

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: [pgAdmin3][Extension]: Wrong SQL generated
Date: 2016-01-18 11:03:36
Message-ID: CAM5-9D8hPH9Hj8mAq+XorWvV7N4xKn5g3PCUj-x6UhhCReiPmQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi all,

While implementing Extension module in pgAdmin4, I came to know that there
is an bug in pgadmin3.

Following are the steps to reproduce it:
1. Edit an existing extension.
2. In definition tab, set schema and version fields to empty.
3. In SQL tab, it generates an sql for the changes made which is wrong, it
shouldn't generate sql for the schema and version field if it is kept
empty, both fields should be validated.

Below is the wrong SQL generated:

*ALTER EXTENSION btree_gin*
* SET SCHEMA ;*
*ALTER EXTENSION btree_gin*
* UPDATE TO ;*

Let me know for any comments.

Thanks
Surinder Kumar

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Neel Patel 2016-01-18 11:22:50 Re: [pgAdmin4] [Patch]: Extension Module
Previous Message Ashesh Vashi 2016-01-18 09:19:55 pgAdmin 4 commit: Chagned the variable control to use the new format of