[pgAdmin4][RM_2424]: Menu Items don't appear in tools menu for modules that are loaded using deps

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin4][RM_2424]: Menu Items don't appear in tools menu for modules that are loaded using deps
Date: 2017-05-29 07:52:00
Message-ID: CAM5-9D86hMaWan8o5ram63dqEPPPkTO8YaaWV5H2fvp-2v2yag@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

*Issue:*

If modules are loaded without any node dependency(i.e: on page load), the
function 'create_menu' is called implicitly to generate menu items.

But when the modules are loaded when its dependent node expands, the
function 'create_menus' has to explicitly call after 'add_menus' from
respective module's template files.

This patch is dependent on patch 'load_modules_js_when_required.patch'

Please find attached patch and review.

Attachment Content-Type Size
RM_2424.patch application/octet-stream 3.9 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Archit PCE2/CE/14/011 2017-05-29 08:14:52 Issue about pgadmin4
Previous Message Murtuza Zabuawala 2017-05-29 06:23:57 Re: feature test timeouts