Re: [pgAdmin4][Patch]: Run MakeFile to generate builds in production mode

Hi Dave,

I have added a new target to run build in 'dev' mode. By default, it will
run in production mode.

By dev mode it means, run `yarn run bundle:dev` and by prod mode, run `yarn
run bundle:prod`.

In Mac bundle, added new target `make appbundle-dev` to generate build with
command `yarn run bundle:dev`. The default target `make appbundle` will run
`yarn run bundle:prod`.

In Windows bundle, If Make.bat file is executed with an argument `dev` like
`./Make.bat x86 dev`, it will call `yarn run bundle:dev` otherwise it will
run `yarn run bundle:prod`

Please find attached patch and review.

Thanks,
Surinder

On Fri, Sep 8, 2017 at 12:28 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> No, let's just have two targets in one makefile. It's only for our
> convenience.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK:http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On 8 Sep 2017, at 05:34, Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
> wrote:
>
> Hi
>
> On Thu, Sep 7, 2017 at 8:48 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Hi
>>
>> On Thu, Sep 7, 2017 at 7:28 AM, Surinder Kumar <
>> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> When we run Webpack in production mode, it performs optimization on code
>>> while in development we don't optimize generated JS and CSS bundles as dev
>>> mode is for developer use.
>>>
>>> So we should run Webpack bundle in production mode when we are
>>> generating bundles for release mode.
>>>
>>
>> Don't we also need a bundle target for dev mode? The patch changes "make
>> bundle" to run "yarn run bundle:prod"
>>
> ​yes I think so.
> We can have two Makefiles - one for dev mode and other for production mode.
>
>>
>>
>>>
>>> *In the second patch:*
>>>
>>> 1) Enabled "*sourced maps*" in production mode as well which will help
>>> in debugging issues.
>>>
>>> 2) Removed "*yarn run linter*" script when Webpack runs in production
>>> mode because it is for developer only to check if there are any syntax
>>> errors in JS modules.
>>>
>>> 3) Removed redundant script command "*yarn run bundle*" as "*yarn run
>>> bundle:dev*" does the same thing.
>>>
>>> Please find an attached patch.
>>>
>>> Thanks,
>>> Surinder
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>