| From: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | [pgAdmin4][Patch]: CanDrop as a function not working |
| Date: | 2016-05-16 14:41:30 |
| Message-ID: | CAM5-9D-G2dJxN6cMbgBmiphagD97PLHKn6-qzUKyEUQH5jaRBQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi,
*Issue*: When we delete a node, it gets deleted successfully, but after
that it binds each sub-nodes of particular node with canDrop method, then
code throws javascript error.
I found that it was caused because canDrop value is set to true by default
in delete_obj callback(node.js), so the function defined for canDrop does't
gets called in the callback.
And, it is regression of commit id:
*26aa5607ad8eb92591e732837e6aa1a0c48f62b3* which was introduced for
Server-group drop functionality. The way it was coded was wrong. so, I have
fixed the issue related to *"Fix dropping of server groups" *in this patch.
| Attachment | Content-Type | Size |
|---|---|---|
| canDrop_function_issue.patch | application/octet-stream | 3.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashesh Vashi | 2016-05-16 17:39:27 | Re: [pgAdmin4][Patch]: CanDrop as a function not working |
| Previous Message | Ashesh Vashi | 2016-05-16 14:21:36 | pgAdmin 4 commit: Fixed misc issues |