Re: [pgAdmin4][Patch]: CanDrop as a function not working

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: CanDrop as a function not working
Date: 2016-05-16 17:39:27
Message-ID: CAG7mmoxNYzwjY1z7xeMcGe0HT_MwvbPpHxixBA5ObdpuvwOHNw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com>

*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi>

On Mon, May 16, 2016 at 8:11 PM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:

> Hi,
>
> *Issue*: When we delete a node, it gets deleted successfully, but after
> that it binds each sub-nodes of particular node with canDrop method, then
> code throws javascript error.
>
> I found that it was caused because canDrop value is set to true by default
> in delete_obj callback(node.js), so the function defined for canDrop does't
> gets called in the callback.
>
> And, it is regression of commit id:
> *26aa5607ad8eb92591e732837e6aa1a0c48f62b3* which was introduced for
> Server-group drop functionality. The way it was coded was wrong. so, I
> have fixed the issue related to *"Fix dropping of server groups" *in this
> patch.
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2016-05-16 17:39:36 pgAdmin 4 commit: Resolved an issue about missing 'canDrop' function ch
Previous Message Surinder Kumar 2016-05-16 14:41:30 [pgAdmin4][Patch]: CanDrop as a function not working